-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix telemetry disable command #9290
Conversation
Minor thought, the right thing to do might be to discard any telemetry data collected from the period this command was broken. |
This comment was marked as resolved.
This comment was marked as resolved.
The Affected versions are $ keystone telemetry disable
telemetry disable is an unknown command As we want to err on the side of consent being missed, I think we could do the following:
The nature of device events being unversioned however results in an ongoing problem that we would not know if device events are coming from a device with
I'm open to feedback on this from the community, and thanks @DavidMulder0 for reporting this. Summary of SQL deletion commandsDELETE FROM "DeviceEvent" WHERE "reportedAt" <= NOW() - INTERVAL '1 year';
DELETE FROM "DeviceEvent" WHERE "reportedAt" >= '2024-04-29';
DELETE FROM "ProjectEvent" WHERE "reportedAt" <= NOW() - INTERVAL '1 year';
DELETE FROM "ProjectEvent" WHERE "reportedAt" >= '2024-04-29'; |
// every informedAt was a copy of device.informedAt, it was copied everywhere | ||
informedAt: existing.device.informedAt, | ||
const replacement: TelemetryVersion2and3 = { | ||
informedAt: null, // re-inform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone has unknowingly missed their opt-out failing, this will re-inform them
|
||
store.set('telemetry', { | ||
...existing, | ||
informedAt: null, // re-inform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone has unknowingly missed their opt-out failing, this will re-inform them
Merged as 830d46d |
No description provided.